mirror of
https://github.com/xen-project/xen.git
synced 2026-10-29 18:50:05 +01:00
Fix external-device-migrate infinite loop.
For some (yet) unknown reason extern-device-migrate is called twice, once with a missing domname argument. The following invocation loops forever: external-device-migrate -domname because "shift 2" never shifts ($# < 2) and $# is always 1. From: Pascal Bouchareine <pascal@gandi.net> Signed-off-by: Keir Fraser <keir@xensource.com>
This commit is contained in:
Keir Fraser committed
1 parent
0741e7c237
commit
36f49d79ff
1 file changed
+6
-5
@@ -16,6 +16,7 @@
|
||||
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
||||
#
|
||||
|
||||
set -x
|
||||
|
||||
# This script is called by XenD for migration of external devices
|
||||
# It does not handle the migration of those devices itself, but
|
||||
@@ -57,11 +58,11 @@ function evaluate_params()
|
||||
stype=""
|
||||
while [ $# -ge 1 ]; do
|
||||
case "$1" in
|
||||
-step) step=$2; shift 2;;
|
||||
-host) host=$2; shift 2;;
|
||||
-domname) domname=$2; shift 2;;
|
||||
-type) typ=$2; shift 2;;
|
||||
-subtype) stype=$2; shift 2;;
|
||||
-step) step=$2; shift; shift;;
|
||||
-host) host=$2; shift; shift;;
|
||||
-domname) domname=$2; shift; shift;;
|
||||
-type) typ=$2; shift; shift;;
|
||||
-subtype) stype=$2; shift; shift;;
|
||||
-recover) recover=1; shift;;
|
||||
-help) ext_dev_migrate_usage; exit 0;;
|
||||
*) break;;
|
||||
|
||||