libxl: correctly initialise yylineno

Sometimes xl would read an uninitialised variable when printing error
messages, resulting in things like this:
  /etc/xen/thing.cfg:1030057088: config parsing error near `"ws08r2-x64-2': lexical error

This is because yylineno is a variable inside the scanner created by
yylex_init, but it is not initialised by yylex_init.
(Debian bug #616099.)

On the way I discovered a lot of complication to do with the calling
convention between bison and flex in reentrant parsers/scanners which
use locations (Debian bug #616100) but as the above change makes the
current code in xen-unstable work I don't propose to do anything else
about that now in our tree.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Tested-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
This commit is contained in:
Ian Jackson committed 2011-03-03 17:11:31 +00:00
1 parent baae0f2bce
commit 3860f61cd1
1 file changed
+3
+3
View File
@@ -43,6 +43,9 @@ static void ctx_dispose(CfgParseContext *ctx) {
static void parse(CfgParseContext *ctx) {
/* On return, ctx.err will be updated with the error status. */
int r;
xlu__cfg_yyset_lineno(1, ctx->scanner);
r= xlu__cfg_yyparse(ctx);
if (r) assert(ctx->err);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.