xl: error if vif backend!=0 is used with run_hotplug_scripts

Print an error and exit if backend!=0 is used in conjunction with
run_hotplug_scripts. Currently libxl can only execute hotplug scripts
from the toolstack domain (the same domain xl is running from).

Added a description and workaround of this issue on
xl-network-configuration.

Signed-off-by: Roger Pau Monne <roger.pau@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Campbell <ian.campbell@citrix.com>
This commit is contained in:
Roger Pau Monne committed 2012-09-14 10:02:49 +01:00
1 parent 02fcb50040
commit 3c73d5f947
2 files changed
+11 -2

No files matched your search

+4 -2
View File
@@ -122,8 +122,10 @@ specified IP address to be used by the guest (blocking all others).
### backend
Specifies the backend domain which this device should attach to. This
defaults to domain 0. Specifying another domain requires setting up a
driver domain which is outside the scope of this document.
defaults to domain 0. This option does not work if `run_hotplug_scripts`
is not disabled in xl.conf (see xl.conf(5) man page for more information
on this option). Specifying another domain requires setting up a driver
domain which is outside the scope of this document.
### rate
+7
View File
@@ -1096,6 +1096,13 @@ static void parse_config_data(const char *config_source,
fprintf(stderr, "Specified backend domain does not exist, defaulting to Dom0\n");
nic->backend_domid = 0;
}
if (nic->backend_domid != 0 && run_hotplug_scripts) {
fprintf(stderr, "ERROR: the vif 'backend=' option "
"cannot be used in conjunction with "
"run_hotplug_scripts, please set "
"run_hotplug_scripts to 0 in xl.conf\n");
exit(EXIT_FAILURE);
}
} else if (!strcmp(p, "rate")) {
parse_vif_rate(&config, (p2 + 1), nic);
} else if (!strcmp(p, "accel")) {
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.