arm: Modify type of actlr to register_t

AArch64 registers are 64bit whereas AArch32 registers
are 32bit or 64bit. MSR/MRS are expecting 64bit values thus
we should get rid of helpers READ/WRITE_SYSREG32
in favour of using READ/WRITE_SYSREG.
We should also use register_t type when reading sysregs
which can correspond to uint64_t or uint32_t.
Even though many AArch64 registers have upper 32bit reserved
it does not mean that they can't be widen in the future.

ACTLR_EL1 system register bits are implementation defined
which means it is possibly a latent bug on current HW as the CPU
implementer may already have decided to use the top 32bit.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
(cherry picked from commit b80470c845)
This commit is contained in:
Michal Orzel authored and Stefano Stabellini committed 2021-07-16 13:14:15 -07:00
1 parent 27e08cb549
commit 41e8d5d47f
2 files changed
+2 -2

No files matched your search

+1 -1
View File
@@ -329,7 +329,7 @@ static void schedule_tail(struct vcpu *prev)
static void continue_new_vcpu(struct vcpu *prev)
{
current->arch.actlr = READ_SYSREG32(ACTLR_EL1);
current->arch.actlr = READ_SYSREG(ACTLR_EL1);
processor_vcpu_initialise(current);
schedule_tail(prev);
+1 -1
View File
@@ -165,7 +165,7 @@ struct arch_vcpu
/* Control Registers */
register_t sctlr;
uint32_t actlr;
register_t actlr;
uint32_t cpacr;
uint32_t contextidr;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.