EFI: don't leak heap contents through XEN_EFI_get_next_variable_name

Commit 1f4eb9d27d ("EFI: fix getting EFI variable list on some
systems") switched to using the caller provided size for the copy-out
without making sure the copied buffer is properly scrubbed.

Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
This commit is contained in:
Jan Beulich committed 2020-02-06 09:52:33 +01:00
1 parent ad38db5852
commit 4783ee894f
1 file changed
+1 -1
+1 -1
View File
@@ -571,7 +571,7 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op)
return -EINVAL;
size = op->u.get_next_variable_name.size;
name.raw = xmalloc_bytes(size);
name.raw = xzalloc_bytes(size);
if ( !name.raw )
return -ENOMEM;
if ( copy_from_guest(name.raw, op->u.get_next_variable_name.name,
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.