x86/spec-ctrl: Fix BTC/SRSO mitigations

We were looking for SCF_entry_ibpb in the wrong variable in the top-of-stack
block, and xen_spec_ctrl won't have had bit 5 set because Xen doesn't
understand SPEC_CTRL_RRSBA_DIS_U yet.

This is XSA-455 / CVE-2024-31142.

Fixes: 53a570b285 ("x86/spec-ctrl: Support IBPB-on-entry")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
Andrew Cooper committed 2024-04-09 16:37:30 +01:00
1 parent 4b3da946ad
commit 489d93cd0f
2 files changed
+2 -2

No files matched your search

+1 -1
View File
@@ -101,7 +101,7 @@ __UNLIKELY_END(nsvm_hap)
/* SPEC_CTRL_ENTRY_FROM_SVM Req: %rsp=regs/cpuinfo, %rdx=0 Clob: acd */
.macro svm_vmexit_cond_ibpb
testb $SCF_entry_ibpb, CPUINFO_xen_spec_ctrl(%rsp)
testb $SCF_entry_ibpb, CPUINFO_spec_ctrl_flags(%rsp)
jz .L_skip_ibpb
mov $MSR_PRED_CMD, %ecx
+1 -1
View File
@@ -90,7 +90,7 @@
jz .L\@_skip
testb $3, UREGS_cs(%rsp)
.else
testb $SCF_entry_ibpb, CPUINFO_xen_spec_ctrl(%rsp)
testb $SCF_entry_ibpb, CPUINFO_spec_ctrl_flags(%rsp)
.endif
jz .L\@_skip
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.