mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
xen: Add deviations for MISRA C:2012 Rule 7.1
As specified in rules.rst, these constants can be used in the code. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Acked-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
Nicola Vetrini authored and Stefano Stabellini committed
1 parent
1003608606
commit
4bee3b9c2c
5 files changed
+33
-28
No files matched your search
@@ -132,10 +132,9 @@ safe."
|
||||
# Series 7.
|
||||
#
|
||||
|
||||
-doc_begin="Usage of the following constants is safe, since they are given as-is
|
||||
in the inflate algorithm specification and there is therefore no risk of them
|
||||
being interpreted as decimal constants."
|
||||
-config=MC3R1.R7.1,literals={safe, "^0(007|37|070|213|236|300|321|330|331|332|333|334|335|337|371)$"}
|
||||
-doc_begin="It is safe to use certain octal constants the way they are defined
|
||||
in specifications, manuals, and algorithm descriptions."
|
||||
-config=MC3R1.R7.1,reports+={safe, "any_area(any_loc(any_exp(text(^.*octal-ok.*$))))"}
|
||||
-doc_end
|
||||
|
||||
-doc_begin="Violations in files that maintainers have asked to not modify in the
|
||||
|
||||
@@ -90,6 +90,12 @@ Deviations related to MISRA C:2012 Rules:
|
||||
- __emulate_2op and __emulate_2op_nobyte
|
||||
- read_debugreg and write_debugreg
|
||||
|
||||
* - R7.1
|
||||
- It is safe to use certain octal constants the way they are defined
|
||||
in specifications, manuals, and algorithm descriptions. Such places
|
||||
are marked safe with a /\* octal-ok \*/ in-code comment.
|
||||
- Tagged as `safe` for ECLAIR.
|
||||
|
||||
* - R7.2
|
||||
- Violations caused by __HYPERVISOR_VIRT_START are related to the
|
||||
particular use of it done in xen_mk_ulong.
|
||||
|
||||
@@ -90,9 +90,9 @@ unsigned int svm_get_insn_len(struct vcpu *v, unsigned int instr_enc)
|
||||
if ( !instr_modrm )
|
||||
return emul_len;
|
||||
|
||||
if ( modrm_mod == MASK_EXTR(instr_modrm, 0300) &&
|
||||
(modrm_reg & 7) == MASK_EXTR(instr_modrm, 0070) &&
|
||||
(modrm_rm & 7) == MASK_EXTR(instr_modrm, 0007) )
|
||||
if ( modrm_mod == MASK_EXTR(instr_modrm, 0300) && /* octal-ok */
|
||||
(modrm_reg & 7) == MASK_EXTR(instr_modrm, 0070) && /* octal-ok */
|
||||
(modrm_rm & 7) == MASK_EXTR(instr_modrm, 0007) ) /* octal-ok */
|
||||
return emul_len;
|
||||
}
|
||||
|
||||
|
||||
+19
-19
@@ -53,25 +53,25 @@ static inline void svm_invlpga(unsigned long linear, uint32_t asid)
|
||||
*/
|
||||
#define INSTR_ENC(opc, modrm) (((opc) << 8) | (modrm))
|
||||
|
||||
#define INSTR_PAUSE INSTR_ENC(X86EMUL_OPC_F3(0, 0x90), 0)
|
||||
#define INSTR_INT3 INSTR_ENC(X86EMUL_OPC( 0, 0xcc), 0)
|
||||
#define INSTR_ICEBP INSTR_ENC(X86EMUL_OPC( 0, 0xf1), 0)
|
||||
#define INSTR_HLT INSTR_ENC(X86EMUL_OPC( 0, 0xf4), 0)
|
||||
#define INSTR_XSETBV INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0321)
|
||||
#define INSTR_VMRUN INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0330)
|
||||
#define INSTR_VMCALL INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0331)
|
||||
#define INSTR_VMLOAD INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0332)
|
||||
#define INSTR_VMSAVE INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0333)
|
||||
#define INSTR_STGI INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0334)
|
||||
#define INSTR_CLGI INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0335)
|
||||
#define INSTR_INVLPGA INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0337)
|
||||
#define INSTR_RDTSCP INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0371)
|
||||
#define INSTR_INVD INSTR_ENC(X86EMUL_OPC(0x0f, 0x08), 0)
|
||||
#define INSTR_WBINVD INSTR_ENC(X86EMUL_OPC(0x0f, 0x09), 0)
|
||||
#define INSTR_WRMSR INSTR_ENC(X86EMUL_OPC(0x0f, 0x30), 0)
|
||||
#define INSTR_RDTSC INSTR_ENC(X86EMUL_OPC(0x0f, 0x31), 0)
|
||||
#define INSTR_RDMSR INSTR_ENC(X86EMUL_OPC(0x0f, 0x32), 0)
|
||||
#define INSTR_CPUID INSTR_ENC(X86EMUL_OPC(0x0f, 0xa2), 0)
|
||||
#define INSTR_PAUSE INSTR_ENC(X86EMUL_OPC_F3(0, 0x90), 0)
|
||||
#define INSTR_INT3 INSTR_ENC(X86EMUL_OPC( 0, 0xcc), 0)
|
||||
#define INSTR_ICEBP INSTR_ENC(X86EMUL_OPC( 0, 0xf1), 0)
|
||||
#define INSTR_HLT INSTR_ENC(X86EMUL_OPC( 0, 0xf4), 0)
|
||||
#define INSTR_XSETBV INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0321) /* octal-ok */
|
||||
#define INSTR_VMRUN INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0330) /* octal-ok */
|
||||
#define INSTR_VMCALL INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0331) /* octal-ok */
|
||||
#define INSTR_VMLOAD INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0332) /* octal-ok */
|
||||
#define INSTR_VMSAVE INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0333) /* octal-ok */
|
||||
#define INSTR_STGI INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0334) /* octal-ok */
|
||||
#define INSTR_CLGI INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0335) /* octal-ok */
|
||||
#define INSTR_INVLPGA INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0337) /* octal-ok */
|
||||
#define INSTR_RDTSCP INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0371) /* octal-ok */
|
||||
#define INSTR_INVD INSTR_ENC(X86EMUL_OPC(0x0f, 0x08), 0)
|
||||
#define INSTR_WBINVD INSTR_ENC(X86EMUL_OPC(0x0f, 0x09), 0)
|
||||
#define INSTR_WRMSR INSTR_ENC(X86EMUL_OPC(0x0f, 0x30), 0)
|
||||
#define INSTR_RDTSC INSTR_ENC(X86EMUL_OPC(0x0f, 0x31), 0)
|
||||
#define INSTR_RDMSR INSTR_ENC(X86EMUL_OPC(0x0f, 0x32), 0)
|
||||
#define INSTR_CPUID INSTR_ENC(X86EMUL_OPC(0x0f, 0xa2), 0)
|
||||
|
||||
unsigned int svm_get_insn_len(struct vcpu *v, unsigned int instr_enc);
|
||||
unsigned int svm_get_task_switch_insn_len(void);
|
||||
|
||||
@@ -1201,8 +1201,8 @@ static int __init gunzip(void)
|
||||
magic[1] = NEXTBYTE();
|
||||
method = NEXTBYTE();
|
||||
|
||||
if (magic[0] != 037 ||
|
||||
((magic[1] != 0213) && (magic[1] != 0236))) {
|
||||
if (magic[0] != 037 || /* octal-ok */
|
||||
((magic[1] != 0213) && (magic[1] != 0236))) { /* octal-ok */
|
||||
error("bad gzip magic numbers");
|
||||
return -1;
|
||||
}
|
||||
|
||||