tools: L2 CAT: support show cbm for L2 CAT.

This patch implements changes in xl/xc changes to support
showing CBM of L2 CAT.

The new level option is introduced to original CAT showing
command in order to show CBM for specified level CAT.
- 'xl psr-cat-show' is updated to show CBM of a domain
  according to input cache level.

Examples:
root@:~$ xl psr-cat-show -l2 1
Socket ID       : 0
Default CBM     : 0xff
   ID                     NAME             CBM
    1                 ubuntu14            0x7f

Signed-off-by: He Chen <he.chen@linux.intel.com>
Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
This commit is contained in:
Yi Sun authored and Jan Beulich committed 2017-08-03 12:39:43 +02:00
1 parent 451a0c39ba
commit 54be79e375
4 files changed
+63 -29

No files matched your search

+1
View File
@@ -2454,6 +2454,7 @@ enum xc_psr_cat_type {
XC_PSR_CAT_L3_CBM = 1,
XC_PSR_CAT_L3_CBM_CODE = 2,
XC_PSR_CAT_L3_CBM_DATA = 3,
XC_PSR_CAT_L2_CBM = 4,
};
typedef enum xc_psr_cat_type xc_psr_cat_type;
+3
View File
@@ -299,6 +299,9 @@ int xc_psr_cat_get_domain_data(xc_interface *xch, uint32_t domid,
case XC_PSR_CAT_L3_CBM_DATA:
cmd = XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA;
break;
case XC_PSR_CAT_L2_CBM:
cmd = XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM;
break;
default:
errno = EINVAL;
return -1;
+2 -1
View File
@@ -557,7 +557,8 @@ struct cmd_spec cmd_table[] = {
{ "psr-cat-show",
&main_psr_cat_show, 0, 1,
"Show Cache Allocation Technology information",
"<Domain>",
"[options] <Domain>",
"-l <level> Specify the cache level to process, otherwise L3 cache is processed\n"
},
#endif
+57 -28
View File
@@ -342,7 +342,7 @@ static void psr_cat_print_one_domain_cbm_type(uint32_t domid, uint32_t socketid,
}
static void psr_cat_print_one_domain_cbm(uint32_t domid, uint32_t socketid,
bool cdp_enabled)
bool cdp_enabled, unsigned int lvl)
{
char *domain_name;
@@ -350,27 +350,38 @@ static void psr_cat_print_one_domain_cbm(uint32_t domid, uint32_t socketid,
printf("%5d%25s", domid, domain_name);
free(domain_name);
if (!cdp_enabled) {
switch (lvl) {
case 3:
if (!cdp_enabled) {
psr_cat_print_one_domain_cbm_type(domid, socketid,
LIBXL_PSR_CBM_TYPE_L3_CBM);
} else {
psr_cat_print_one_domain_cbm_type(domid, socketid,
LIBXL_PSR_CBM_TYPE_L3_CBM_CODE);
psr_cat_print_one_domain_cbm_type(domid, socketid,
LIBXL_PSR_CBM_TYPE_L3_CBM_DATA);
}
break;
case 2:
psr_cat_print_one_domain_cbm_type(domid, socketid,
LIBXL_PSR_CBM_TYPE_L3_CBM);
} else {
psr_cat_print_one_domain_cbm_type(domid, socketid,
LIBXL_PSR_CBM_TYPE_L3_CBM_CODE);
psr_cat_print_one_domain_cbm_type(domid, socketid,
LIBXL_PSR_CBM_TYPE_L3_CBM_DATA);
LIBXL_PSR_CBM_TYPE_L2_CBM);
break;
default:
printf("Input lvl %d is wrong!", lvl);
break;
}
printf("\n");
}
static int psr_cat_print_domain_cbm(uint32_t domid, uint32_t socketid,
bool cdp_enabled)
bool cdp_enabled, unsigned int lvl)
{
int i, nr_domains;
libxl_dominfo *list;
if (domid != INVALID_DOMID) {
psr_cat_print_one_domain_cbm(domid, socketid, cdp_enabled);
psr_cat_print_one_domain_cbm(domid, socketid, cdp_enabled, lvl);
return 0;
}
@@ -380,49 +391,59 @@ static int psr_cat_print_domain_cbm(uint32_t domid, uint32_t socketid,
}
for (i = 0; i < nr_domains; i++)
psr_cat_print_one_domain_cbm(list[i].domid, socketid, cdp_enabled);
psr_cat_print_one_domain_cbm(list[i].domid, socketid, cdp_enabled, lvl);
libxl_dominfo_list_free(list, nr_domains);
return 0;
}
static int psr_cat_print_socket(uint32_t domid, libxl_psr_cat_info *info)
static int psr_cat_print_socket(uint32_t domid, libxl_psr_cat_info *info,
unsigned int lvl)
{
int rc;
uint32_t l3_cache_size;
rc = libxl_psr_cmt_get_l3_cache_size(ctx, info->id, &l3_cache_size);
if (rc) {
fprintf(stderr, "Failed to get l3 cache size for socket:%d\n",
info->id);
return -1;
printf("%-16s: %u\n", "Socket ID", info->id);
/* So far, CMT only supports L3 cache. */
if (lvl == 3) {
rc = libxl_psr_cmt_get_l3_cache_size(ctx, info->id, &l3_cache_size);
if (rc) {
fprintf(stderr, "Failed to get l3 cache size for socket:%d\n",
info->id);
return -1;
}
printf("%-16s: %uKB\n", "L3 Cache", l3_cache_size);
}
printf("%-16s: %u\n", "Socket ID", info->id);
printf("%-16s: %uKB\n", "L3 Cache", l3_cache_size);
printf("%-16s: %#llx\n", "Default CBM", (1ull << info->cbm_len) - 1);
if (info->cdp_enabled)
printf("%5s%25s%16s%16s\n", "ID", "NAME", "CBM (code)", "CBM (data)");
else
printf("%5s%25s%16s\n", "ID", "NAME", "CBM");
return psr_cat_print_domain_cbm(domid, info->id, info->cdp_enabled);
return psr_cat_print_domain_cbm(domid, info->id, info->cdp_enabled, lvl);
}
static int psr_cat_show(uint32_t domid)
static int psr_cat_show(uint32_t domid, unsigned int lvl)
{
int i, nr;
int rc;
libxl_psr_cat_info *info;
rc = libxl_psr_cat_get_info(ctx, &info, &nr, 3);
if (lvl != 2 && lvl != 3) {
fprintf(stderr, "Input lvl %d is wrong\n", lvl);
return EXIT_FAILURE;
}
rc = libxl_psr_cat_get_info(ctx, &info, &nr, lvl);
if (rc) {
fprintf(stderr, "Failed to get cat info\n");
fprintf(stderr, "Failed to get %s cat info\n", (lvl == 3)?"L3":"L2");
return rc;
}
for (i = 0; i < nr; i++) {
rc = psr_cat_print_socket(domid, info + i);
rc = psr_cat_print_socket(domid, info + i, lvl);
if (rc)
goto out;
}
@@ -533,11 +554,19 @@ int main_psr_cat_cbm_set(int argc, char **argv)
int main_psr_cat_show(int argc, char **argv)
{
int opt;
int opt = 0;
uint32_t domid;
unsigned int lvl = 3;
SWITCH_FOREACH_OPT(opt, "", NULL, "psr-cat-show", 0) {
/* No options */
static struct option opts[] = {
{"level", 1, 0, 'l'},
COMMON_LONG_OPTS
};
SWITCH_FOREACH_OPT(opt, "l:", opts, "psr-cat-show", 0) {
case 'l':
lvl = atoi(optarg);
break;
}
if (optind >= argc)
@@ -549,7 +578,7 @@ int main_psr_cat_show(int argc, char **argv)
return 2;
}
return psr_cat_show(domid);
return psr_cat_show(domid, lvl);
}
int main_psr_hwinfo(int argc, char **argv)
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.