vtpmmgr: Check req_len before unpacking command

vtpm_handle_cmd doesn't ensure there is enough space before unpacking
the req buffer.  Add a minimum size check.  Called functions will have
to do their own checking if they need more data from the request.

The error case is tricky since abort_egress wants to rely with a
corresponding tag.  Just hardcode TPM_TAG_RQU_COMMAND since the vtpm is
sending in malformed commands in the first place.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>
This commit is contained in:
Jason Andryuk authored and Andrew Cooper committed 2021-05-10 14:50:33 +01:00
1 parent c8d8a1e2e6
commit 5974702bdd
1 file changed
+6
+6
View File
@@ -840,6 +840,12 @@ TPM_RESULT vtpmmgr_handle_cmd(
UINT32 size;
TPM_COMMAND_CODE ord;
if (tpmcmd->req_len < sizeof_TPM_RQU_HEADER(tpmcmd->req)) {
status = TPM_BAD_PARAMETER;
tag = TPM_TAG_RQU_COMMAND;
goto abort_egress;
}
unpack_TPM_RQU_HEADER(tpmcmd->req,
&tag, &size, &ord);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.