xen/arm: p2m: Switch the p2m lock from spinlock to rwlock

P2M reads do not require to be serialized. This will add contention
when PV drivers are using multi-queue because parallel grant
map/unmaps/copies will happen on DomU's p2m.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
This commit is contained in:
Julien Grall authored and Stefano Stabellini committed 2016-07-28 17:41:55 -07:00
1 parent 01e60f9cc7
commit 5dca4f3ca7
2 files changed
+8 -7

No files matched your search

+6 -6
View File
@@ -49,27 +49,27 @@ static bool_t p2m_mapping(lpae_t pte)
static inline void p2m_write_lock(struct p2m_domain *p2m)
{
spin_lock(&p2m->lock);
write_lock(&p2m->lock);
}
static inline void p2m_write_unlock(struct p2m_domain *p2m)
{
spin_unlock(&p2m->lock);
write_unlock(&p2m->lock);
}
static inline void p2m_read_lock(struct p2m_domain *p2m)
{
spin_lock(&p2m->lock);
read_lock(&p2m->lock);
}
static inline void p2m_read_unlock(struct p2m_domain *p2m)
{
spin_unlock(&p2m->lock);
read_unlock(&p2m->lock);
}
static inline int p2m_is_locked(struct p2m_domain *p2m)
{
return spin_is_locked(&p2m->lock);
return rw_is_locked(&p2m->lock);
}
void p2m_dump_info(struct domain *d)
@@ -1388,7 +1388,7 @@ int p2m_init(struct domain *d)
struct p2m_domain *p2m = &d->arch.p2m;
int rc = 0;
spin_lock_init(&p2m->lock);
rwlock_init(&p2m->lock);
INIT_PAGE_LIST_HEAD(&p2m->pages);
p2m->vmid = INVALID_VMID;
+2 -1
View File
@@ -3,6 +3,7 @@
#include <xen/mm.h>
#include <xen/radix-tree.h>
#include <xen/rwlock.h>
#include <public/vm_event.h> /* for vm_event_response_t */
#include <public/memory.h>
#include <xen/p2m-common.h>
@@ -20,7 +21,7 @@ extern void memory_type_changed(struct domain *);
/* Per-p2m-table state */
struct p2m_domain {
/* Lock that protects updates to the p2m */
spinlock_t lock;
rwlock_t lock;
/* Pages used to construct the p2m */
struct page_list_head pages;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.