tools/libfsimage: Fix clean and distclean make targets

If there is a single colon for a given target and the target
is redefined in another place (e.g. in included file) then
make executes only new target and displays following warning:

Makefile:35: warning: overriding commands for target `clean'
tools/libfsimage/common/../../../tools/libfsimage/Rules.mk:25:
warning: ignoring old commands for target `clean'

To cope with that issue define all required targets as double-colon
rules. Additionally, remove some redundant stuff.

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
This commit is contained in:
Daniel Kiper authored and Ian Campbell committed 2013-05-13 10:57:17 +01:00
1 parent 2569c54743
commit 667d8a84b2
2 files changed
+3 -3

No files matched your search

+1 -1
View File
@@ -21,7 +21,7 @@ fs-install: fs-all
$(FSLIB): $(PIC_OBJS)
$(CC) $(LDFLAGS) $(SHLIB_LDFLAGS) -o $@ $^ -lfsimage $(FS_LIBDEPS) $(APPEND_LDFLAGS)
clean distclean:
clean distclean::
rm -f $(PIC_OBJS) $(FSLIB) $(DEPS)
-include $(DEPS)
+2 -2
View File
@@ -31,8 +31,8 @@ install: all
$(INSTALL_DATA) fsimage_plugin.h $(DESTDIR)$(INCLUDEDIR)
$(INSTALL_DATA) fsimage_grub.h $(DESTDIR)$(INCLUDEDIR)
clean distclean:
rm -f $(PIC_OBJS) $(LIB) $(DEPS)
clean distclean::
rm -f $(LIB)
libfsimage.so: libfsimage.so.$(MAJOR)
ln -sf $< $@
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.