x86/cpuidle: replace a pointless NULL check

The address of an array slot can't be NULL. Instead add a bounds check
to make sure the array indexing is valid (the check is against 2 since
slot zero of the array - corresponding to C0 - is of no interest here).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
Jan Beulich committed 2018-08-02 12:12:07 +02:00
1 parent 9e26b58fa7
commit 68465944c8
1 file changed
+3 -3
+3 -3
View File
@@ -759,11 +759,11 @@ void acpi_dead_idle(void)
struct acpi_processor_power *power;
struct acpi_processor_cx *cx;
if ( (power = processor_powers[smp_processor_id()]) == NULL )
if ( (power = processor_powers[smp_processor_id()]) == NULL ||
power->count < 2 )
goto default_halt;
if ( (cx = &power->states[power->count-1]) == NULL )
goto default_halt;
cx = &power->states[power->count - 1];
if ( cx->entry_method == ACPI_CSTATE_EM_FFH )
{
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.