x86/vmx: optimize vmx_read/write_guest_msr()

Replace linear scan with vmx_find_msr().  This way the time complexity
of searching for required MSR reduces from linear to logarithmic.

Signed-off-by: Sergey Dyasli <sergey.dyasli@citrix.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
Sergey Dyasli authored and Andrew Cooper committed 2017-02-27 10:22:20 +00:00
1 parent 9b93c6b369
commit 7f11aa4b2b
1 file changed
+8 -18
+8 -18
View File
@@ -1358,17 +1358,12 @@ struct vmx_msr_entry *vmx_find_msr(u32 msr, int type)
int vmx_read_guest_msr(u32 msr, u64 *val)
{
struct vcpu *curr = current;
unsigned int i, msr_count = curr->arch.hvm_vmx.msr_count;
const struct vmx_msr_entry *msr_area = curr->arch.hvm_vmx.msr_area;
struct vmx_msr_entry *ent;
for ( i = 0; i < msr_count; i++ )
if ( (ent = vmx_find_msr(msr, VMX_GUEST_MSR)) != NULL )
{
if ( msr_area[i].index == msr )
{
*val = msr_area[i].data;
return 0;
}
*val = ent->data;
return 0;
}
return -ESRCH;
@@ -1376,17 +1371,12 @@ int vmx_read_guest_msr(u32 msr, u64 *val)
int vmx_write_guest_msr(u32 msr, u64 val)
{
struct vcpu *curr = current;
unsigned int i, msr_count = curr->arch.hvm_vmx.msr_count;
struct vmx_msr_entry *msr_area = curr->arch.hvm_vmx.msr_area;
struct vmx_msr_entry *ent;
for ( i = 0; i < msr_count; i++ )
if ( (ent = vmx_find_msr(msr, VMX_GUEST_MSR)) != NULL )
{
if ( msr_area[i].index == msr )
{
msr_area[i].data = val;
return 0;
}
ent->data = val;
return 0;
}
return -ESRCH;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.