wait: drop wake_up_{all,one}()

wake_up_one() isn't used at all, so violates Misra rule 2.1 (unreachable
code). wake_up_all() is only used locally, yet rather than making it
static its sole user can invoke wake_up_nr() in the intended way directly.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
Jan Beulich committed 2026-02-24 10:30:10 +01:00
1 parent a42a4e3ea5
commit 88009f9edd
2 files changed
+1 -13

No files matched your search

+1 -11
View File
@@ -87,7 +87,7 @@ void init_waitqueue_head(struct waitqueue_head *wq)
void destroy_waitqueue_head(struct waitqueue_head *wq)
{
wake_up_all(wq);
wake_up_nr(wq, UINT_MAX);
}
void wake_up_nr(struct waitqueue_head *wq, unsigned int nr)
@@ -107,16 +107,6 @@ void wake_up_nr(struct waitqueue_head *wq, unsigned int nr)
spin_unlock(&wq->lock);
}
void wake_up_one(struct waitqueue_head *wq)
{
wake_up_nr(wq, 1);
}
void wake_up_all(struct waitqueue_head *wq)
{
wake_up_nr(wq, UINT_MAX);
}
#ifdef CONFIG_X86
static void __prepare_to_wait(struct waitqueue_vcpu *wqv)
-2
View File
@@ -31,8 +31,6 @@ void destroy_waitqueue_head(struct waitqueue_head *wq);
/* Wake VCPU(s) waiting on specified waitqueue. */
void wake_up_nr(struct waitqueue_head *wq, unsigned int nr);
void wake_up_one(struct waitqueue_head *wq);
void wake_up_all(struct waitqueue_head *wq);
/* Wait on specified waitqueue until @condition is true. */
#define wait_event(wq, condition) \
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.