x86/shadow: correct GFN use by sh_unshadow_for_p2m_change()

Luckily sh_remove_all_mappings()'s use of the parameter is limited to
generation of log messages. Nevertheless we'd better pass correct GFNs
around:
- the incoming GFN, when replacing a large page, may not be large page
  aligned,
- incrementing by page-size-scaled values can't be right.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Tim Deegan <tim@xen.org>
This commit is contained in:
Jan Beulich committed 2020-10-30 14:27:23 +01:00
1 parent 0b841314da
commit 92bc186320
1 file changed
+3 -2
+3 -2
View File
@@ -3121,6 +3121,8 @@ static void sh_unshadow_for_p2m_change(struct domain *d, unsigned long gfn,
&& mfn_valid(nmfn) )
npte = map_domain_page(nmfn);
gfn &= ~(L1_PAGETABLE_ENTRIES - 1);
for ( i = 0; i < L1_PAGETABLE_ENTRIES; i++ )
{
if ( !npte
@@ -3129,8 +3131,7 @@ static void sh_unshadow_for_p2m_change(struct domain *d, unsigned long gfn,
{
/* This GFN->MFN mapping has gone away */
sh_remove_all_shadows_and_parents(d, omfn);
if ( sh_remove_all_mappings(d, omfn,
_gfn(gfn + (i << PAGE_SHIFT))) )
if ( sh_remove_all_mappings(d, omfn, _gfn(gfn + i)) )
cpumask_or(&flushmask, &flushmask, d->dirty_cpumask);
}
omfn = mfn_add(omfn, 1);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.