tools/libs: guest: Fix Arm build after 8fc4916daf

Gitlab CI spotted an issue when building the tools Arm:

xg_dom_arm.c: In function 'meminit':
xg_dom_arm.c:401:50: error: passing argument 3 of 'set_mode' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  401 |     rc = set_mode(dom->xch, dom->guest_domid, dom->guest_type);
      |                                               ~~~^~~~~~~~~~~~

This is because the const was not propagated in the Arm code. Fix it
by constifying the 3rd parameter of set_mode().

Fixes: 8fc4916daf ("tools/libs: guest: Use const whenever we point to literal strings")
Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
Julien Grall committed 2021-05-19 13:35:54 +01:00
1 parent 01d84420fb
commit 935abe1cc4
1 file changed
+1 -1
+1 -1
View File
@@ -195,7 +195,7 @@ static int vcpu_arm64(struct xc_dom_image *dom)
/* ------------------------------------------------------------------------ */
static int set_mode(xc_interface *xch, uint32_t domid, char *guest_type)
static int set_mode(xc_interface *xch, uint32_t domid, const char *guest_type)
{
static const struct {
char *guest;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.