mirror of
https://github.com/xen-project/xen.git
synced 2026-10-29 18:50:05 +01:00
x86/pv: Correctly fold vIOPL back into vcpu_guest_context
c/s f71ecb6 "x86: introduce a new VMASSIST for architectural behaviour of
iopl" shifted the vcpu iopl field by 12, but didn't update the logic which
reconstructs the guests eflags for migration.
Existing guest kernels set a vIOPL of 1, to prevent them from faulting when
accessing IO ports. This bug manifests as a crash after migrate, as the vIOPL
reverts back to the default of 0, and the guest suffers an unexpected #GP
fault.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
This commit is contained in:
1 parent
7f3f61699b
commit
972523bcef
1 file changed
+1
-1
@@ -1512,7 +1512,7 @@ void arch_get_info_guest(struct vcpu *v, vcpu_guest_context_u c)
|
||||
|
||||
/* IOPL privileges are virtualised: merge back into returned eflags. */
|
||||
BUG_ON((c(user_regs.eflags) & X86_EFLAGS_IOPL) != 0);
|
||||
c(user_regs.eflags |= v->arch.pv_vcpu.iopl << 12);
|
||||
c(user_regs.eflags |= v->arch.pv_vcpu.iopl);
|
||||
|
||||
if ( !compat )
|
||||
{
|
||||
|
||||