x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}()

In the latter case the variable altogether is then unused and hence gets
dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly
introduced both assignments in 57a57465da ("x86/HVM: use available
linear->phys translations in REP MOVS/STOS handling"), likely as a
result of some re-work on the patch.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Paul Durrant <paul@xen.org>
This commit is contained in:
Jan Beulich committed 2023-08-07 11:20:15 +02:00
1 parent e55146071d
commit a628e73de1
1 file changed
+1 -3
+1 -3
View File
@@ -1861,7 +1861,6 @@ static int cf_check hvmemul_rep_movs(
return rc;
}
bytes = PAGE_SIZE - (daddr & ~PAGE_MASK);
if ( hvio->mmio_access.write_access &&
(hvio->mmio_gla == (daddr & PAGE_MASK)) &&
/* See comment above. */
@@ -1988,7 +1987,7 @@ static int cf_check hvmemul_rep_stos(
container_of(ctxt, struct hvm_emulate_ctxt, ctxt);
struct vcpu *curr = current;
struct hvm_vcpu_io *hvio = &curr->arch.hvm.hvm_io;
unsigned long addr, bytes;
unsigned long addr;
paddr_t gpa;
p2m_type_t p2mt;
bool_t df = !!(ctxt->regs->eflags & X86_EFLAGS_DF);
@@ -1998,7 +1997,6 @@ static int cf_check hvmemul_rep_stos(
if ( rc != X86EMUL_OKAY )
return rc;
bytes = PAGE_SIZE - (addr & ~PAGE_MASK);
if ( hvio->mmio_access.write_access &&
(hvio->mmio_gla == (addr & PAGE_MASK)) &&
/* See respective comment in MOVS processing. */
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.