xen/x86: Use %*pb[l] instead of cpumask_scn{,list}printf()

This removes all use of keyhandler_scratch as a bounce-buffer for the rendered
string.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
Andrew Cooper committed 2018-11-16 16:25:54 +00:00
1 parent 29da63789f
commit ad63707307
3 files changed
+10 -13

No files matched your search

+6 -3
View File
@@ -535,9 +535,12 @@ void mcheck_cmn_handler(const struct cpu_user_regs *regs)
mc_panic("MCE: No CPU found valid MCE, need reset");
if ( !cpumask_empty(&mce_fatal_cpus) )
{
char *ebufp, ebuf[96] = "MCE: Fatal error happened on CPUs ";
ebufp = ebuf + strlen(ebuf);
cpumask_scnprintf(ebufp, 95 - strlen(ebuf), &mce_fatal_cpus);
char ebuf[96];
snprintf(ebuf, sizeof(ebuf),
"MCE: Fatal error happened on CPUs %*pb",
nr_cpu_ids, cpumask_bits(&mce_fatal_cpus));
mc_panic(ebuf);
}
atomic_set(&found_error, 0);
+2 -5
View File
@@ -159,11 +159,8 @@ static void nmi_shootdown_cpus(void)
if ( cpumask_empty(&waiting_to_crash) )
printk("Shot down all CPUs\n");
else
{
cpulist_scnprintf(keyhandler_scratch, sizeof keyhandler_scratch,
&waiting_to_crash);
printk("Failed to shoot down CPUs {%s}\n", keyhandler_scratch);
}
printk("Failed to shoot down CPUs {%*pbl}\n",
nr_cpu_ids, cpumask_bits(&waiting_to_crash));
/* Crash shutdown any IOMMU functionality as the crashdump kernel is not
* happy when booting if interrupt/dma remapping is still enabled */
+2 -5
View File
@@ -2302,11 +2302,8 @@ static void dump_irqs(unsigned char key)
spin_lock_irqsave(&desc->lock, flags);
cpumask_scnprintf(keyhandler_scratch, sizeof(keyhandler_scratch),
desc->affinity);
printk(" IRQ:%4d affinity:%s vec:%02x type=%-15s"
" status=%08x ",
irq, keyhandler_scratch, desc->arch.vector,
printk(" IRQ:%4d affinity:%*pb vec:%02x type=%-15s status=%08x ",
irq, nr_cpu_ids, cpumask_bits(desc->affinity), desc->arch.vector,
desc->handler->typename, desc->status);
if ( ssid )
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.