mirror of
https://github.com/xen-project/xen.git
synced 2026-10-29 10:40:03 +01:00
x86/cpuid: Fix handling of the CPUID.7[0].eax levelling MSR
7a0 is an integer field, not a mask - taking the logical and of the hardware and policy values results in nonsense. Instead, take the policy value directly. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Reviewed-by: Roger Pau Monné <roger.pau@cirtrix.com> Reviewed-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
1 parent
af5793cac2
commit
b50d78d0ea
1 file changed
+9
-4
@@ -218,11 +218,16 @@ static int update_domain_cpuid_info(struct domain *d,
|
||||
if ( is_pv_domain(d) && ((levelling_caps & LCAP_7ab0) == LCAP_7ab0) )
|
||||
{
|
||||
uint64_t mask = cpuidmask_defaults._7ab0;
|
||||
uint32_t eax = ctl->eax;
|
||||
uint32_t ebx = p->feat._7b0;
|
||||
|
||||
if ( boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON) )
|
||||
mask &= ((uint64_t)eax << 32) | ebx;
|
||||
/*
|
||||
* Leaf 7[0].eax is max_subleaf, not a feature mask. Take it
|
||||
* wholesale from the policy, but clamp the features in 7[0].ebx
|
||||
* per usual.
|
||||
*/
|
||||
if ( boot_cpu_data.x86_vendor &
|
||||
(X86_VENDOR_AMD | X86_VENDOR_HYGON) )
|
||||
mask = (((uint64_t)p->feat.max_subleaf << 32) |
|
||||
((uint32_t)mask & p->feat._7b0));
|
||||
|
||||
d->arch.pv.cpuidmasks->_7ab0 = mask;
|
||||
}
|
||||
|
||||