ioreq: allow arch_vcpu_ioreq_completion() to signal an error

Return false from arch_vcpu_ioreq_completion() when completion is not handled.
According to coding-best-practices.pandoc an error should be propagated to
caller, if caller is expecting to handle it, which seems to the case for
callers of arch_vcpu_ioreq_completion().

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
Sergiy Kibrik authored and Jan Beulich committed 2025-02-25 08:41:07 +01:00
1 parent e16acd8067
commit b7056d684c
2 files changed
+2 -2

No files matched your search

+1 -1
View File
@@ -47,7 +47,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion)
default:
ASSERT_UNREACHABLE();
break;
return false;
}
return true;
+1 -1
View File
@@ -118,7 +118,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion);
static inline bool arch_vcpu_ioreq_completion(enum vio_completion completion)
{
ASSERT_UNREACHABLE();
return true;
return false;
}
#endif
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.