xen/arm: Save/Restore GICH_APR register

Linux uses GICC_CTLR.EOImodeNS set to 0, which means both priority drop and
deactivate interrupt functionality are made when something is written in
GICC_EOIR.

As the ARM manual specifies: "having an active interrupt in the List registers
with a priority that is not set in the corresponding Active Priorities
register" when GICV_CTLR.EOImode (ie GICC_CTLR.EOImodeNS in the guest context)
result in unpredicable behavior, we need to save/restore GICH_APR.

Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
This commit is contained in:
Julien Grall authored and Ian Campbell committed 2013-04-11 14:23:31 +01:00
1 parent 3e27e36ca5
commit b952c687fa
1 file changed
+2
+2
View File
@@ -70,6 +70,7 @@ void gic_save_state(struct vcpu *v)
v->arch.gic_lr[i] = GICH[GICH_LR + i];
v->arch.lr_mask = this_cpu(lr_mask);
spin_unlock_irq(&gic.lock);
v->arch.gic_apr = GICH[GICH_APR];
/* Disable until next VCPU scheduled */
GICH[GICH_HCR] = 0;
isb();
@@ -87,6 +88,7 @@ void gic_restore_state(struct vcpu *v)
for ( i=0; i<nr_lrs; i++)
GICH[GICH_LR + i] = v->arch.gic_lr[i];
spin_unlock_irq(&gic.lock);
GICH[GICH_APR] = v->arch.gic_apr;
GICH[GICH_HCR] = GICH_HCR_EN;
isb();
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.