xen/arm: grant-table: Correct the prototype of the arch helpers

Both the stub and the x86 prototypes for replace_grant_host_mapping()
and create_grant_host_mapping() will define the first parameter (and
third for the former) as uint64_t. Yet Arm will define it as
'unsigned long'.

While there are no differences for 64-bit, for 32-bit it means
that the address should be truncated as 32-bit guest could support
up to 40-bit addresses.

So replace 'unsigned long' with 'uint64_t' for the first parameter
(and third parameter for replace_grant_host_mapping()).

Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Henry Wang <Henry.Wang@arm.com>
Tested-by: Henry Wang <Henry.Wang@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
This commit is contained in:
Julien Grall committed 2023-07-04 19:23:02 +01:00
1 parent 6e06d229d5
commit c53384ea2f
2 files changed
+6 -6

No files matched your search

+3 -3
View File
@@ -36,10 +36,10 @@ static inline bool gnttab_release_host_mappings(const struct domain *d)
return true;
}
int create_grant_host_mapping(unsigned long gpaddr, mfn_t frame,
int create_grant_host_mapping(uint64_t gpaddr, mfn_t frame,
unsigned int flags, unsigned int cache_flags);
int replace_grant_host_mapping(unsigned long gpaddr, mfn_t frame,
unsigned long new_gpaddr, unsigned int flags);
int replace_grant_host_mapping(uint64_t gpaddr, mfn_t frame,
uint64_t new_gpaddr, unsigned int flags);
/*
* The region used by Xen on the memory will never be mapped in DOM0
+3 -3
View File
@@ -1579,7 +1579,7 @@ void put_page_type(struct page_info *page)
return;
}
int create_grant_host_mapping(unsigned long gpaddr, mfn_t frame,
int create_grant_host_mapping(uint64_t gpaddr, mfn_t frame,
unsigned int flags, unsigned int cache_flags)
{
int rc;
@@ -1600,8 +1600,8 @@ int create_grant_host_mapping(unsigned long gpaddr, mfn_t frame,
return GNTST_okay;
}
int replace_grant_host_mapping(unsigned long gpaddr, mfn_t frame,
unsigned long new_gpaddr, unsigned int flags)
int replace_grant_host_mapping(uint64_t gpaddr, mfn_t frame,
uint64_t new_gpaddr, unsigned int flags)
{
gfn_t gfn = gaddr_to_gfn(gpaddr);
struct domain *d = current->domain;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.