xen/arm: smmu: Set/clear IOMMU domain for device

When a device is assigned/de-assigned it is required to properly set
IOMMU domain used to protect the device. This assignment was missing,
thus it was not possible to de-assign the device:

(XEN) Deassigning device 0000:03:00.0 from dom2
(XEN) smmu: 0000:03:00.0:  not attached to domain 2
(XEN) d2: deassign (0000:03:00.0) failed (-3)

Fix this by assigning IOMMU domain on arm_smmu_assign_dev and reset it
to NULL on arm_smmu_deassign_dev.

Fixes: 06d1f7a278 ("xen/arm: smmuv1: Keep track of S2CR state")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
This commit is contained in:
Oleksandr Andrushchenko authored and Julien Grall committed 2021-08-24 10:08:25 +00:00
1 parent 93713f444b
commit c7669d3652
1 file changed
+2
+2
View File
@@ -2768,6 +2768,7 @@ static int arm_smmu_assign_dev(struct domain *d, u8 devfn,
arm_smmu_destroy_iommu_domain(domain);
} else {
atomic_inc(&domain->ref);
dev_iommu_domain(dev) = domain;
}
out:
@@ -2791,6 +2792,7 @@ static int arm_smmu_deassign_dev(struct domain *d, struct device *dev)
spin_lock(&xen_domain->lock);
arm_smmu_detach_dev(domain, dev);
dev_iommu_domain(dev) = NULL;
atomic_dec(&domain->ref);
if (domain->ref.counter == 0)
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.