mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
x86/mm: replace bogus assertion in paging_log_dirty_op()
While I was the one to introduce it, I don't think it is correct: A
bogus continuation call issued by a tool stack domain may find another
continuation in progress. IOW we've been asserting caller controlled
state (which is reachable only via a domctl), and the early (lock-less)
check in paging_domctl() helps in a limited way only.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
master commit: 0956aa2219
master date: 2023-05-03 13:38:30 +0200
This commit is contained in:
1 parent
aa2c921c1e
commit
cbbf877545
1 file changed
+2
-2
@@ -440,8 +440,8 @@ static int paging_log_dirty_op(struct domain *d,
|
||||
d->arch.paging.preempt.op != sc->op )
|
||||
{
|
||||
paging_unlock(d);
|
||||
ASSERT(!resuming);
|
||||
domain_unpause(d);
|
||||
if ( !resuming )
|
||||
domain_unpause(d);
|
||||
return -EBUSY;
|
||||
}
|
||||
|
||||
|
||||