mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 10:11:27 +01:00
x86/cpu: identify uninitialized CPU data using BAD_APICID
Uninitialized cpu_data[] entries have the apicid field set to BAD_APICID,
not boot_cpu_data.apicid. Fix the check in cpu_smpboot_free() to use the
correct condition.
Fixes: 7126b7f806 ("x86/CPU: re-work populating of cpu_data[]")
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Teddy Astie <teddy.astie@vates.tech>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
Roger Pau Monne authored and Andrew Cooper committed
1 parent
9e13c0ca18
commit
cd0413bfac
1 file changed
+1
-2
@@ -961,8 +961,7 @@ static void cpu_smpboot_free(unsigned int cpu, bool remove)
|
||||
* In that case the socket number cannot be relied upon, but the respective
|
||||
* socket_cpumask[] slot also wouldn't have been set.
|
||||
*/
|
||||
if ( c[cpu].apicid != boot_cpu_data.apicid &&
|
||||
cpumask_empty(socket_cpumask[socket]) )
|
||||
if ( c[cpu].apicid != BAD_APICID && cpumask_empty(socket_cpumask[socket]) )
|
||||
{
|
||||
xfree(socket_cpumask[socket]);
|
||||
socket_cpumask[socket] = NULL;
|
||||
|
||||