VT-d/RMRR: Adjust the return values of register_one_rmrr()

Adjust/manage the return values of register_one_rmrr() such that new
callers log errors for non-debug builds too, while not affecting the
behavior of the original callers.

Signed-off-by: Venu Busireddy <venu.busireddy@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
This commit is contained in:
Venu Busireddy authored and Jan Beulich committed 2017-02-07 14:31:03 +01:00
1 parent 30921dc2df
commit d0de76af1c
1 file changed
+11
+11
View File
@@ -619,6 +619,7 @@ static int register_one_rmrr(struct acpi_rmrr_unit *rmrru)
rmrru->base_address, rmrru->end_address);
scope_devices_free(&rmrru->scope);
xfree(rmrru);
return 1;
}
else if ( rmrru->base_address > rmrru->end_address )
{
@@ -691,7 +692,17 @@ acpi_parse_one_rmrr(struct acpi_dmar_header *header)
&rmrru->scope, RMRR_TYPE, rmrr->segment);
if ( !ret && (rmrru->scope.devices_cnt != 0) )
{
ret = register_one_rmrr(rmrru);
/*
* register_one_rmrr() returns greater than 0 when a specified
* PCIe device cannot be detected. To prevent VT-d from being
* disabled in such cases, reset the return value to 0 here.
*/
if ( ret > 0 )
ret = 0;
}
else
xfree(rmrru);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.