mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
libelf: address MISRA C:2012 Rule 5.3
The types u{8,16,32,64} defined in 'xen/arch/x86/include/asm/types.h'
shadow the variables in the modified function, hence violating Rule 5.3.
Therefore, the rename takes care of the shadowing.
No functional changes.
Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
This commit is contained in:
1 parent
202a341fd4
commit
d63ea6c46b
1 file changed
+12
-12
@@ -91,10 +91,10 @@ uint64_t elf_access_unsigned(struct elf_binary * elf, elf_ptrval base,
|
||||
{
|
||||
elf_ptrval ptrval = base + moreoffset;
|
||||
bool need_swap = elf_swap(elf);
|
||||
const uint8_t *u8;
|
||||
const uint16_t *u16;
|
||||
const uint32_t *u32;
|
||||
const uint64_t *u64;
|
||||
const uint8_t *pu8;
|
||||
const uint16_t *pu16;
|
||||
const uint32_t *pu32;
|
||||
const uint64_t *pu64;
|
||||
|
||||
if ( !elf_access_ok(elf, ptrval, size) )
|
||||
return 0;
|
||||
@@ -102,17 +102,17 @@ uint64_t elf_access_unsigned(struct elf_binary * elf, elf_ptrval base,
|
||||
switch ( size )
|
||||
{
|
||||
case 1:
|
||||
u8 = (const void*)ptrval;
|
||||
return *u8;
|
||||
pu8 = (const void *)ptrval;
|
||||
return *pu8;
|
||||
case 2:
|
||||
u16 = (const void*)ptrval;
|
||||
return need_swap ? bswap_16(*u16) : *u16;
|
||||
pu16 = (const void *)ptrval;
|
||||
return need_swap ? bswap_16(*pu16) : *pu16;
|
||||
case 4:
|
||||
u32 = (const void*)ptrval;
|
||||
return need_swap ? bswap_32(*u32) : *u32;
|
||||
pu32 = (const void *)ptrval;
|
||||
return need_swap ? bswap_32(*pu32) : *pu32;
|
||||
case 8:
|
||||
u64 = (const void*)ptrval;
|
||||
return need_swap ? bswap_64(*u64) : *u64;
|
||||
pu64 = (const void *)ptrval;
|
||||
return need_swap ? bswap_64(*pu64) : *pu64;
|
||||
default:
|
||||
return 0;
|
||||
}
|
||||
|
||||