mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
libxc: remove null pointer checks in xc_pm_get_{c, p}xstat
We don't check for null pointers in similar functions, and it's silly to do so for these arguments here anyway; they should fail noisily if null is passed. While at it, remove pointless brackets. Coverity-ID: 1055938 Coverity-ID: 1055939 Signed-off-by: Matthew Daley <mattjd@gmail.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> Acked-by: Ian Campbell <ian.campbell@citrix.com>
This commit is contained in:
1 parent
492da27a3e
commit
d6dea2f6ab
1 file changed
+2
-2
+2
-2
@@ -51,7 +51,7 @@ int xc_pm_get_pxstat(xc_interface *xch, int cpuid, struct xc_px_stat *pxpt)
|
||||
|
||||
int max_px, ret;
|
||||
|
||||
if ( !pxpt || !(pxpt->trans_pt) || !(pxpt->pt) )
|
||||
if ( !pxpt->trans_pt || !pxpt->pt )
|
||||
return -EINVAL;
|
||||
|
||||
if ( (ret = xc_pm_get_max_px(xch, cpuid, &max_px)) != 0)
|
||||
@@ -128,7 +128,7 @@ int xc_pm_get_cxstat(xc_interface *xch, int cpuid, struct xc_cx_stat *cxpt)
|
||||
DECLARE_NAMED_HYPERCALL_BOUNCE(residencies, cxpt->residencies, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH);
|
||||
int max_cx, ret;
|
||||
|
||||
if( !cxpt || !(cxpt->triggers) || !(cxpt->residencies) )
|
||||
if( !cxpt->triggers || !cxpt->residencies )
|
||||
return -EINVAL;
|
||||
|
||||
if ( (ret = xc_pm_get_max_cx(xch, cpuid, &max_cx)) )
|
||||
|
||||