mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
tools/libxc: Fix HVM_PARAM_PAE_ENABLED handling in xc_cpuid_apply_policy()
Despite as suggested in c/s 685e922d6f, not all HVM_PARAMs are handled
in the same way. HVM_PARAM_PAE_ENABLED is a toolstack-only value, and
the xc_cpuid_apply_policy() used to be the only consumer.
Reinstate the old behaviour (mad as it is) to avoid regressions.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
1 parent
4599d472f1
commit
d79cc6bc2b
1 file changed
+12
@@ -579,6 +579,8 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid,
|
||||
}
|
||||
else
|
||||
{
|
||||
uint64_t val;
|
||||
|
||||
/*
|
||||
* Topology for HVM guests is entirely controlled by Xen. For now, we
|
||||
* hardcode APIC_ID = vcpu_id * 2 to give the illusion of no SMT.
|
||||
@@ -632,6 +634,16 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid,
|
||||
break;
|
||||
}
|
||||
|
||||
/*
|
||||
* HVM_PARAM_PAE_ENABLED is a parameter to this function, stashed in
|
||||
* Xen. Nothing else has ever taken notice of the value.
|
||||
*/
|
||||
rc = xc_hvm_param_get(xch, domid, HVM_PARAM_PAE_ENABLED, &val);
|
||||
if ( rc )
|
||||
goto out;
|
||||
|
||||
p->basic.pae = val;
|
||||
|
||||
/*
|
||||
* These settings are necessary to cause earlier HVM_PARAM_NESTEDHVM /
|
||||
* XEN_DOMCTL_disable_migrate settings to be reflected correctly in
|
||||
|
||||