libxl: add initializers for libxl__domid_history

This patch fixes Coverity issue CID 1459006 (Insecure data handling
(INTEGER_OVERFLOW)).

The problem is that the error paths for libxl__mark_domid_recent() and
libxl__is_domid_recent() check the 'f' field in struct libxl__domid_history
when it may not have been initialized.

Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Acked-by: Wei Liu <wl@xen.org>
This commit is contained in:
Paul Durrant authored and Wei Liu committed 2020-02-26 21:48:39 +00:00
1 parent 767cfe0859
commit d7d751bfdb
1 file changed
+2 -2
+2 -2
View File
@@ -1390,7 +1390,7 @@ static int libxl__read_recent(libxl__gc *gc,
static int libxl__mark_domid_recent(libxl__gc *gc, uint32_t domid)
{
libxl__flock *lock;
struct libxl__domid_history ctxt;
struct libxl__domid_history ctxt = {};
char *new;
FILE *nf = NULL;
int r, rc;
@@ -1461,7 +1461,7 @@ out:
int libxl__is_domid_recent(libxl__gc *gc, uint32_t domid, bool *recent)
{
struct libxl__domid_history ctxt;
struct libxl__domid_history ctxt = {};
int rc;
rc = libxl__open_domid_history(gc, &ctxt);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.