mirror of
https://github.com/xen-project/xen.git
synced 2026-10-29 18:50:05 +01:00
xen/arm: Use dt_device_match to avoid multiple if conditions
There is some place in Xen ARM code where multiple if conditions is used check the presence of a node or find a node. These pieces of code can be replace by an array and using proper device tree helpers. Signed-off-by: Julien Grall <julien.grall@linaro.org> Acked-by: Ian Campbell <ian.campbell@citrix.com>
This commit is contained in:
1 parent
34743911e7
commit
d90abf9aa6
3 files changed
+18
-6
No files matched your search
@@ -437,15 +437,20 @@ static int map_device(struct domain *d, const struct dt_device_node *dev)
|
||||
|
||||
static int handle_node(struct domain *d, const struct dt_device_node *np)
|
||||
{
|
||||
static const struct dt_device_match skip_matches[] __initconst =
|
||||
{
|
||||
DT_MATCH_COMPATIBLE("xen,xen"),
|
||||
DT_MATCH_TYPE("memory"),
|
||||
DT_MATCH_PATH("/chosen"),
|
||||
{ /* sentinel */ },
|
||||
};
|
||||
const struct dt_device_node *child;
|
||||
int res;
|
||||
|
||||
DPRINT("handle %s\n", dt_node_full_name(np));
|
||||
|
||||
/* Skip theses nodes and the sub-nodes */
|
||||
if ( dt_device_is_compatible(np, "xen,xen") ||
|
||||
dt_device_type_is_equal(np, "memory") ||
|
||||
!strcmp("/chosen", dt_node_full_name(np)) )
|
||||
if ( dt_match_node(skip_matches, np ) )
|
||||
return 0;
|
||||
|
||||
if ( dt_device_used_by(np) != DOMID_XEN )
|
||||
|
||||
+6
-3
@@ -101,14 +101,17 @@ static uint32_t calibrate_timer(void)
|
||||
/* Set up the timer on the boot CPU */
|
||||
int __init init_xen_time(void)
|
||||
{
|
||||
static const struct dt_device_match timer_ids[] __initconst =
|
||||
{
|
||||
DT_MATCH_TIMER,
|
||||
{ /* sentinel */ },
|
||||
};
|
||||
struct dt_device_node *dev;
|
||||
int res;
|
||||
unsigned int i;
|
||||
u32 rate;
|
||||
|
||||
dev = dt_find_compatible_node(NULL, NULL, "arm,armv7-timer");
|
||||
if ( !dev )
|
||||
dev = dt_find_compatible_node(NULL, NULL, "arm,armv8-timer");
|
||||
dev = dt_find_matching_node(NULL, timer_ids);
|
||||
if ( !dev )
|
||||
panic("Unable to find a compatible timer in the device tree\n");
|
||||
|
||||
|
||||
@@ -1,6 +1,10 @@
|
||||
#ifndef __ARM_TIME_H__
|
||||
#define __ARM_TIME_H__
|
||||
|
||||
#define DT_MATCH_TIMER \
|
||||
DT_MATCH_COMPATIBLE("arm,armv7-timer"), \
|
||||
DT_MATCH_COMPATIBLE("arm,armv8-timer")
|
||||
|
||||
typedef unsigned long cycles_t;
|
||||
|
||||
static inline cycles_t get_cycles (void)
|
||||
|
||||