xen: Add missing va_end() in hypercall_create_continuation()

The documentation requires va_start() to always be matched with a
corresponding va_end(). However, this is not the case in the path used
for bad format.

This was introduced by XSA-296.

Coverity-ID: 1488727
Fixes: 0bf9f8d3e3 ("xen/hypercall: Don't use BUG() for parameter checking in hypercall_create_continuation()")
Signed-off-by: Julien Grall <julien@xen.org>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
This commit is contained in:
Julien Grall authored and Andrew Cooper committed 2019-11-21 15:50:01 +00:00
1 parent 83ac5ab54b
commit df7a19338a
2 files changed
+2

No files matched your search

+1
View File
@@ -467,6 +467,7 @@ unsigned long hypercall_create_continuation(
return rc;
bad_fmt:
va_end(args);
gprintk(XENLOG_ERR, "Bad hypercall continuation format '%c'\n", *p);
ASSERT_UNREACHABLE();
domain_crash(current->domain);
+1
View File
@@ -157,6 +157,7 @@ unsigned long hypercall_create_continuation(
return op;
bad_fmt:
va_end(args);
gprintk(XENLOG_ERR, "Bad hypercall continuation format '%c'\n", *p);
ASSERT_UNREACHABLE();
domain_crash(curr->domain);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.