mirror of
https://github.com/xen-project/xen.git
synced 2026-10-29 18:50:05 +01:00
xen/x86: Identify legitimate fallthrough cases
The case in arch_set_info_guest() is a legitimate fallthrough. Mark it as such. The cases in vlapic_accept_irq() are a terminal error path, but Coverity fails to spot this. Reorder the comment to the end. No functional change, but fixes two MISSING_BREAK Coverity defects. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
This commit is contained in:
1 parent
e3566c190c
commit
e763268781
2 files changed
+2
-2
No files matched your search
@@ -1223,6 +1223,7 @@ int arch_set_info_guest(
|
||||
{
|
||||
case -EINTR:
|
||||
rc = -ERESTART;
|
||||
/* Fallthrough */
|
||||
case -ERESTART:
|
||||
v->arch.old_guest_table =
|
||||
pagetable_get_page(v->arch.guest_table);
|
||||
|
||||
@@ -374,8 +374,7 @@ static void vlapic_accept_irq(struct vcpu *v, uint32_t icr_low)
|
||||
|
||||
case APIC_DM_INIT:
|
||||
case APIC_DM_STARTUP:
|
||||
/* Handled in vlapic_ipi(). */
|
||||
BUG();
|
||||
BUG(); /* Handled in vlapic_ipi(). */
|
||||
|
||||
default:
|
||||
gdprintk(XENLOG_ERR, "TODO: unsupported delivery mode in ICR %x\n",
|
||||
|
||||