xl: make return type of create_domain() more consistent.

create_domain() is of uint32_t return type, because on
success it returns the domid of the new domain, and
uint32_t is what we typically use for domid-s.

However, on failure, it returns ERROR_FAIL or ERROR_INVAL,
which are -3 and -6. Callers assign the return value to an
'int rc' variable and then check for '(rc < 0)'.

Although things work, and no tool (compiler, Coverity, ecc.)
is complaining, using 'int' as return type seems better.

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
This commit is contained in:
Dario Faggioli authored and Ian Jackson committed 2016-04-08 15:07:20 +01:00
1 parent 0742044fd4
commit eeecf9d761
1 file changed
+1 -1
+1 -1
View File
@@ -2777,7 +2777,7 @@ static void evdisable_disk_ejects(libxl_evgen_disk_eject **diskws,
}
}
static uint32_t create_domain(struct domain_create *dom_info)
static int create_domain(struct domain_create *dom_info)
{
uint32_t domid = INVALID_DOMID;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.