mirror of
https://github.com/xen-project/xen.git
synced 2026-10-29 18:50:05 +01:00
xl: make return type of create_domain() more consistent.
create_domain() is of uint32_t return type, because on success it returns the domid of the new domain, and uint32_t is what we typically use for domid-s. However, on failure, it returns ERROR_FAIL or ERROR_INVAL, which are -3 and -6. Callers assign the return value to an 'int rc' variable and then check for '(rc < 0)'. Although things work, and no tool (compiler, Coverity, ecc.) is complaining, using 'int' as return type seems better. Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com>
This commit is contained in:
1 parent
0742044fd4
commit
eeecf9d761
1 file changed
+1
-1
@@ -2777,7 +2777,7 @@ static void evdisable_disk_ejects(libxl_evgen_disk_eject **diskws,
|
||||
}
|
||||
}
|
||||
|
||||
static uint32_t create_domain(struct domain_create *dom_info)
|
||||
static int create_domain(struct domain_create *dom_info)
|
||||
{
|
||||
uint32_t domid = INVALID_DOMID;
|
||||
|
||||
|
||||