credit: update timeslice under lock

When updating the timeslice of the credit scheduler protect the
scheduler's private data by it's lock. Today a possible race could
result only in some weird scheduling decisions during one timeslice,
but further adjustments will need the lock anyway.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
This commit is contained in:
Juergen Gross authored and Jan Beulich committed 2016-02-02 14:03:06 +01:00
1 parent 949fea109e
commit f2c96ac4de
1 file changed
+5
+5
View File
@@ -1101,6 +1101,7 @@ csched_sys_cntl(const struct scheduler *ops,
int rc = -EINVAL;
xen_sysctl_credit_schedule_t *params = &sc->u.sched_credit;
struct csched_private *prv = CSCHED_PRIV(ops);
unsigned long flags;
switch ( sc->cmd )
{
@@ -1112,8 +1113,12 @@ csched_sys_cntl(const struct scheduler *ops,
|| params->ratelimit_us < XEN_SYSCTL_SCHED_RATELIMIT_MIN))
|| MICROSECS(params->ratelimit_us) > MILLISECS(params->tslice_ms) )
goto out;
spin_lock_irqsave(&prv->lock, flags);
__csched_set_tslice(prv, params->tslice_ms);
prv->ratelimit_us = params->ratelimit_us;
spin_unlock_irqrestore(&prv->lock, flags);
/* FALLTHRU */
case XEN_SYSCTL_SCHEDOP_getinfo:
params->tslice_ms = prv->tslice_ms;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.