mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
tools/libxenevtchn: check xenevtchn_open() flags for not supported bits
Refuse a call of xenevtchn_open() with unsupported bits in flags being set. This will change behavior for callers passing junk in flags today, but those would otherwise get probably unwanted side effects when the flags they specify today get any meaning. So checking flags is the right thing to do. Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
1 parent
1997d379dc
commit
f7918dc8f9
1 file changed
+9
-1
@@ -13,6 +13,7 @@
|
||||
* License along with this library; If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#include <errno.h>
|
||||
#include <unistd.h>
|
||||
#include <stdlib.h>
|
||||
|
||||
@@ -31,9 +32,16 @@ static int all_restrict_cb(Xentoolcore__Active_Handle *ah, domid_t domid)
|
||||
|
||||
xenevtchn_handle *xenevtchn_open(xentoollog_logger *logger, unsigned int flags)
|
||||
{
|
||||
xenevtchn_handle *xce = malloc(sizeof(*xce));
|
||||
xenevtchn_handle *xce;
|
||||
int rc;
|
||||
|
||||
if ( flags )
|
||||
{
|
||||
errno = EINVAL;
|
||||
return NULL;
|
||||
}
|
||||
|
||||
xce = malloc(sizeof(*xce));
|
||||
if ( !xce )
|
||||
return NULL;
|
||||
|
||||
|
||||