mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
tools/ocaml: fix 32-bit truncation bug in stub_xc_domain_setmaxmem()
Observed when attempting to boot a >4TiB VM: After a call to domain_setmaxmem with 6370254848 (KiB), the domain's maxmem got set to 2075287552, which is exactly 2^32 smaller. xc_domain_setmaxmem takes an uint64_t as a parameter, and the OCaml value is 64-bit already, so fix the C variable to match the type and avoid the truncation. Fixes:f5b43e95fa("libxl: fix "xl mem-set" regression from 0c029c4da2") Signed-off-by: Edwin Török <edwin.torok@citrix.com> Acked-by: Christian Lindig <christian.lindig@cloud.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> (cherry picked from commit381b4ff16f)
This commit is contained in:
1 parent
27bf8182db
commit
f833d29a3a
1 file changed
+1
-1
@@ -934,7 +934,7 @@ CAMLprim value stub_xc_domain_setmaxmem(value xch_val, value domid,
|
||||
int retval;
|
||||
|
||||
uint32_t c_domid = Int_val(domid);
|
||||
unsigned int c_max_memkb = Int64_val(max_memkb);
|
||||
uint64_t c_max_memkb = Int64_val(max_memkb);
|
||||
caml_enter_blocking_section();
|
||||
retval = xc_domain_setmaxmem(xch, c_domid, c_max_memkb);
|
||||
caml_leave_blocking_section();
|
||||
|
||||