mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
x86/PV: drop dead paging_update_paging_modes() call during Dom0 construction
The function won't ever be invoked, as paging_mode_enabled() always
returns false here due to the immediately preceding clearing of
d->arch.paging.mode. While compilers recognize this and eliminate the
call, make this explicit in the source (which likely 9a28170f2d ["pvh
dom0: construct_dom0 changes"] should have done right away, albeit even
before that the call looks to have been pointless - shadow mode enabling
has occurred later virtually forever).
While there also update an adjacent partly stale comment.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
1 parent
5d58062192
commit
f90a265f5b
1 file changed
+2
-6
@@ -10,7 +10,6 @@
|
||||
#include <xen/init.h>
|
||||
#include <xen/libelf.h>
|
||||
#include <xen/multiboot.h>
|
||||
#include <xen/paging.h>
|
||||
#include <xen/pfn.h>
|
||||
#include <xen/sched.h>
|
||||
#include <xen/softirq.h>
|
||||
@@ -804,11 +803,8 @@ int __init dom0_construct_pv(struct domain *d,
|
||||
|
||||
d->arch.paging.mode = 0;
|
||||
|
||||
/* Set up CR3 value for write_ptbase */
|
||||
if ( paging_mode_enabled(d) )
|
||||
paging_update_paging_modes(v);
|
||||
else
|
||||
update_cr3(v);
|
||||
/* Set up CR3 value for switch_cr3_cr4(). */
|
||||
update_cr3(v);
|
||||
|
||||
/* We run on dom0's page tables for the final part of the build process. */
|
||||
switch_cr3_cr4(cr3_pa(v->arch.cr3), read_cr4());
|
||||
|
||||