mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
x86/nmi: Check MSR_MISC_ENABLE for all Intel platforms
Right now it's only checked in setup_p4_watchdog(), and not in setup_p6_watchdog(). Perform the check in the common Intel path in setup_apic_nmi_watchdog(), and pass misc_enable as a parameter into setup_p4_watchdog() to avoid reading it twice. Fixes:0dfba864fb("NMI watchdog support in Xen.") Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Reviewed-by: Jan Beulich <jbeulich@suse.com> master commit:dfb428cb11master date: 2026-08-18 12:51:08 +0100
This commit is contained in:
1 parent
aa4c4909b4
commit
f98206e8a1
1 file changed
+12
-8
+12
-8
@@ -347,14 +347,8 @@ static void setup_p6_watchdog(unsigned counter)
|
||||
wrmsrns(MSR_P6_EVNTSEL(0), evntsel);
|
||||
}
|
||||
|
||||
static void setup_p4_watchdog(void)
|
||||
static void setup_p4_watchdog(uint64_t misc_enable)
|
||||
{
|
||||
uint64_t misc_enable;
|
||||
|
||||
rdmsrl(MSR_IA32_MISC_ENABLE, misc_enable);
|
||||
if (!(misc_enable & MSR_IA32_MISC_ENABLE_PERF_AVAIL))
|
||||
return;
|
||||
|
||||
nmi_perfctr_msr = MSR_P4_IQ_PERFCTR0;
|
||||
nmi_p4_cccr_val = P4_NMI_IQ_CCCR0;
|
||||
if ( boot_cpu_data.x86_num_siblings == 2 )
|
||||
@@ -386,6 +380,8 @@ static void setup_p4_watchdog(void)
|
||||
|
||||
void setup_apic_nmi_watchdog(void)
|
||||
{
|
||||
uint64_t misc;
|
||||
|
||||
if ( nmi_watchdog == NMI_NONE )
|
||||
return;
|
||||
|
||||
@@ -396,6 +392,14 @@ void setup_apic_nmi_watchdog(void)
|
||||
break;
|
||||
|
||||
case X86_VENDOR_INTEL:
|
||||
misc = rdmsr(MSR_IA32_MISC_ENABLE);
|
||||
|
||||
if ( !(misc & MSR_IA32_MISC_ENABLE_PERF_AVAIL) )
|
||||
{
|
||||
printk(XENLOG_WARNING "Intel Perfmon unavailable\n");
|
||||
break;
|
||||
}
|
||||
|
||||
switch ( boot_cpu_data.family )
|
||||
{
|
||||
case 6:
|
||||
@@ -404,7 +408,7 @@ void setup_apic_nmi_watchdog(void)
|
||||
: CORE_EVENT_CPU_CLOCKS_NOT_HALTED);
|
||||
break;
|
||||
case 15:
|
||||
setup_p4_watchdog();
|
||||
setup_p4_watchdog(misc);
|
||||
break;
|
||||
}
|
||||
break;
|
||||
|
||||