pvh/dom0: warn when dom0_mem is not set

There have been several reports of the dom0 builder running out of
memory when building a PVH dom0 without having specified a dom0_mem
value. Print a warning message if dom0_mem is not set when booting in
PVH mode.

This is a temporary workaround until accounting for internal memory
required by Xen (ie: paging structures) is improved.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
This commit is contained in:
Roger Pau Monné authored and Jan Beulich committed 2019-02-18 13:44:53 +01:00
1 parent 6fa1755644
commit fbaa0e58f3
1 file changed
+10
+10
View File
@@ -378,8 +378,18 @@ unsigned long __init dom0_compute_nr_pages(
* maximum of 128MB.
*/
if ( !nr_pages )
{
nr_pages = avail - (pv_shim ? pv_shim_mem(avail)
: min(avail / 16, 128UL << (20 - PAGE_SHIFT)));
if ( is_hvm_domain(d) && !need_paging )
/*
* Temporary workaround message until internal (paging) memory
* accounting required to build a pvh dom0 is improved.
*/
printk("WARNING: PVH dom0 without dom0_mem set is still unstable. "
"If you get crashes during boot, try adding a dom0_mem parameter\n");
}
/* Clamp according to min/max limits and available memory. */
nr_pages = max(nr_pages, min_pages);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.