x86/PCI: fix guest_io_read() when pci_cfg_ok() denies access

For a multi-byte aligned read, this so far resulted in 0x00ff to be
put in the guest's register rather than 0xffff or 0xffffffff, which in
turn could confuse bus scanning functions (which, when reading vendor
and/or device IDs, expect to get back all zeroes or all ones).

As the value gets masked to the read width when merging back into the
full result, setting the initial value to all ones should not harm any
or the other cases.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
This commit is contained in:
Jan Beulich committed 2012-06-22 10:04:30 +02:00
1 parent b1a4a51944
commit fdcf7a9316
1 file changed
+1 -1
+1 -1
View File
@@ -1717,7 +1717,7 @@ static uint32_t guest_io_read(
while ( bytes != 0 )
{
unsigned int size = 1;
uint32_t sub_data = 0xff;
uint32_t sub_data = ~0;
if ( (port == 0x42) || (port == 0x43) || (port == 0x61) )
{
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.