libxc: correct memory range check in domain builder

Commit 81a76e4b12 ("libxc: rework of
domain builder's page table handler") introduced a regression with
checking the required memory size of the domain. The needed maximum pfn
of the initial kernel mapping was added to the currently last used pfn
resulting in doubling the estimated memory need.

Correct the calculation of the last needed pfn to enable booting of
small domains again.

Reported-by: Anthony Perard <anthony.perard@citrix.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Tested-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
This commit is contained in:
Juergen Gross authored and Ian Campbell committed 2016-02-08 15:28:21 +00:00
1 parent fb24954e51
commit fe52f6a47e
1 file changed
+2 -3
+2 -3
View File
@@ -164,7 +164,7 @@ static int count_pgtables(struct xc_dom_image *dom, xen_vaddr_t from,
for ( l = domx86->params->levels - 1; l >= 0; l-- )
{
map->lvls[l].pfn = pfn + map->area.pgtables;
map->lvls[l].pfn = dom->pfn_alloc_end + map->area.pgtables;
if ( l == domx86->params->levels - 1 )
{
/* Top level page table in first mapping only. */
@@ -238,8 +238,7 @@ static int alloc_pgtables(struct xc_dom_image *dom)
try_virt_end = round_up(dom->virt_alloc_end + pages * PAGE_SIZE_X86,
bits_to_mask(22)); /* 4MB alignment */
if ( count_pgtables(dom, dom->parms.virt_base, try_virt_end,
dom->pfn_alloc_end) )
if ( count_pgtables(dom, dom->parms.virt_base, try_virt_end, 0) )
return -1;
pages = map->area.pgtables + extra_pages;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.