Ian Campbell bb13728842 xl: close nullfd after dup2'ing it to stdin ...

We assert that nullfd if not std{in,out,err} since that would result
in closing one of the just dup2'd fds. For this to happen
std{in,out,err} would have needed to be closed, at which point all
sorts of other things could go wrong.

CID: 1130519

It was previously hypothesised[0] that fixing 1130516 would solve this
too, but that appears to not have been the case.

Compile tested only.

[0] http://lists.xenproject.org/archives/html/xen-devel/2013-11/msg02931.html

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: andrew.cooper3@citrix.com
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

2016-03-01 13:38:50 +00:00

..

blktap2

blktap2: Use RING_COPY_REQUEST

2015-12-18 09:49:43 -05:00

console

tools/console: correct make dependencies for _paths.h

2016-02-11 16:34:46 +00:00

debugger

tools: Do not expose all builds to unstable hypercall APIs by default

2016-02-04 15:20:40 +00:00

examples

docs: get rid of the SEDF scheduler

2015-07-08 14:37:43 +01:00

firmware

hvmloader: fix scratch_alloc to avoid overlaps

2016-02-10 14:46:45 +01:00

flask

loadpolicy: only close polFd if it is valid

2016-02-29 10:48:49 -05:00

helpers

init-xenstore-domain: cleanup all resources on a single exit path

2016-02-11 15:36:15 +00:00

hotplug

tools: don't stop xenstore domain when stopping dom0

2016-01-18 16:35:56 +00:00

include

tools: update outdated header comment on privcmd.h

2015-12-02 15:24:14 +00:00

libfsimage

Replace FSF street address with canonical URL

2015-07-29 11:14:07 +01:00

libs

libxenevtchn: rename evtchn_port_or_errot_t as xenevtchn_port...

2016-02-04 15:19:30 +00:00

libvchan

libxenevtchn: rename evtchn_port_or_errot_t as xenevtchn_port...

2016-02-04 15:19:30 +00:00

libxc

migration/save: pass checkpointed_stream from libxl to libxc

2016-02-26 15:14:46 +00:00

libxl

xl: close nullfd after dup2'ing it to stdin

2016-03-01 13:38:50 +00:00

memshr

Replace FSF street address with canonical URL

2015-07-29 11:14:07 +01:00

misc

tools: gtracestat: make all functions and global data static

2016-02-19 16:44:03 +00:00

ocaml

tools: Do not expose all builds to unstable hypercall APIs by default

2016-02-04 15:20:40 +00:00

pygrub

tools: pygrub: if partition table is empty, try treating as a whole disk

2015-11-16 11:01:50 +00:00

python

tools: Refactor foreign memory mapping into libxenforeignmemory

2016-01-22 12:24:03 +00:00

tests

x86emul: limit-check branch targets

2016-02-26 12:14:39 +01:00

xcutils

tools: Refactor hypercall calling wrappers into libxencall.

2016-01-22 12:23:30 +00:00

xenbackendd

Replace FSF street address with canonical URL

2015-07-29 11:14:07 +01:00

xenmon

xenmon: initialise dummy array

2016-02-11 15:12:18 +00:00

xenpaging

xenpaging: don't try to log via xch if xc_interface_close fails

2016-02-19 16:45:10 +00:00

xenpmd

Replace FSF street address with canonical URL

2015-07-29 11:14:07 +01:00

xenstat

xenstat: handle more than 1024 domains

2016-01-19 10:42:37 +00:00

xenstore

xenstore: add stddef.h to xenstore_lib.h

2016-02-03 11:24:54 +00:00

xentrace

tools/xenalyze: Actually handle case where number of ipi vectors exceeds static max

2016-02-29 11:12:53 -05:00

config.h.in

xen/arm: Propagate clock-frequency to DOMU if present in the DT timer node

2015-06-25 10:59:08 +01:00

configure

m4/python: fix typo in LDFLAGS variable name

2016-02-22 16:13:56 +00:00

configure.ac

tools: Honor Config.mk debug value, rather than setting our own

2015-09-02 13:07:57 +01:00

cross-install

cross-install: Only apply in tools directory, and automatically wrap $INSTALL.

2008-08-30 08:36:02 +01:00

Makefile

tools: probe for existence of qemu-xen stderr trace backend.

2016-02-11 16:33:54 +00:00

Rules.mk

tools: Do not expose all builds to unstable hypercall APIs by default

2016-02-04 15:20:40 +00:00